ci(*): update helm-chart-smoketest.yml, add wasmtime-v1 coverage#605
Merged
vdice merged 2 commits intospinframework:mainfrom Mar 17, 2026
Merged
Conversation
11 tasks
b01c353 to
70ced6e
Compare
b6d98cd to
5839a54
Compare
Collaborator
Author
|
@kate-goldenring this should be ready for a re-review. Note that this PR does rely on the following fix (specifically for the wasmtime shim): #604 |
2d68a1e to
6c89440
Compare
Contributor
Contributor
kate-goldenring
left a comment
There was a problem hiding this comment.
Just a few cleanup notes to improve maintainability.
7c574c1 to
453b402
Compare
kate-goldenring
previously approved these changes
Mar 16, 2026
453b402 to
04adf37
Compare
Signed-off-by: Vaughn Dice <vdice@akamai.com>
…meoptions if k3d Signed-off-by: Vaughn Dice <vdice@akamai.com>
04adf37 to
59f59c0
Compare
kate-goldenring
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Notes:
Issue ticket number and link
Depends on #604 (Can rebase after that lands)
Closes #602