Incorporate minor updates from the standard library#353
Open
djdv wants to merge 15 commits intospf13:masterfrom
Open
Incorporate minor updates from the standard library#353djdv wants to merge 15 commits intospf13:masterfrom
djdv wants to merge 15 commits intospf13:masterfrom
Conversation
fredbi
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the source for this pkg, I noticed the usage of
bytes.Bufferin places where Go 1.10'sstrings.Buildercould be used instead. (It's intended for this and is marginally more performant by avoiding some copies internally)While migrating over, I found a handful of other small linting changes that seem acceptable.
All that is included here, but anything can be dropped if it's not desired.
I don't expect this to change any of observable behavior and the tests pass, but who knows.