Improve tree search efficiency#7941
Closed
foozleface wants to merge 1 commit intospecify:mainfrom
Closed
Conversation
| import { tables } from '../../DataModel/tables'; | ||
| import { queryFieldFilterSpecs } from '../../QueryBuilder/FieldFilterSpec'; | ||
| import { makeComboBoxQuery } from '../helpers'; | ||
| import { QUERY_COMBO_BOX_SEARCH_LIMIT } from '../index'; |
Member
There was a problem hiding this comment.
This isn't included in this PR
grantfitzsimmons
requested changes
Apr 10, 2026
Member
grantfitzsimmons
left a comment
grantfitzsimmons
left a comment
There was a problem hiding this comment.
Testing instructions
- Open a form with a tree-based QueryComboBox (e.g., Taxon field on a Determination)
- Type a few characters and verify the typeahead dropdown populates quickly
- Check user preferences -- the tree search algorithm should now default to "starts with"
- Run the frontend tests:
npx jest --testPathPattern treeSearchEfficiency
This is pretty simple, just changing the default preference, but it does speed up searches. The automatic test is not passing, however.
github-project-automation
Bot
moved this from 📋Back Log
to Dev Attention Needed
in General Tester Board
foozleface
force-pushed
the
cas/perf-tree-search-7752
branch
from
e15b0f4 to
d0e2aa3
Compare
Collaborator
Author
|
Fixed —
All 3 tests pass locally: |
|
|
||
| // Typeahead dropdown doesn't need 1000 results — 50 is more than enough. | ||
| // Reducing this from 1000 also cuts the DB query cost significantly. | ||
| export const QUERY_COMBO_BOX_SEARCH_LIMIT = 50; |
Member
There was a problem hiding this comment.
I'd prefer that we fetch query combo box results in batches on scroll rather than limiting it to 50
Change default tree search algorithm from 'contains' (LIKE '%x%') to 'startsWith' (LIKE 'x%'), enabling B-tree index usage on 200K+ row tree tables. Replace hardcoded limit of 1000 with paginated batch-on-scroll loading: - Initial fetch returns first 50 results (QUERY_COMBO_BOX_PAGE_SIZE) - Scrolling near the bottom of the dropdown fetches the next 50 - Loading indicator shown while fetching more results - Continues until all results are loaded Changes: - UserDefinitions.tsx: default treeSearchAlgorithm 'contains' -> 'startsWith' - QueryComboBox/index.tsx: paginated fetchSource with handleScrollEnd - AutoComplete.tsx: onScrollEnd, isLoadingMore, extraItems props - treeSearchEfficiency.test.tsx: verify default operator and page size
foozleface
force-pushed
the
cas/perf-tree-search-7752
branch
from
d0e2aa3 to
57ac51a
Compare
Collaborator
Author
|
Updated per feedback — replaced the hard limit of 50 with batch-on-scroll pagination:
The All 12 tests across AutoComplete + QueryComboBox suites pass. |
5 tasks
Member
|
Moved to this PR with additional fixes #8016 |
github-project-automation
Bot
moved this from Dev Attention Needed
to ✅Done
in General Tester Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7752
Contributed by @foozleface
Tree search in QueryComboBox sends a LIKE query per keystroke. On tree tables with 200K+ rows, using "contains" mode generates
LIKE '%pattern%'which cannot use B-tree indexes and causes full table scans. This PR changes the default search mode from "contains" to "startsWith", enablingLIKE 'pattern%'which uses B-tree indexes. It also reduces the search result limit from 1000 to 50, since a typeahead dropdown never needs that many results.Implementation
treeSearchAlgorithmuser preference fromcontainstostartsWithinUserDefinitions.tsxQUERY_COMBO_BOX_SEARCH_LIMITconstant set to 50 (was 1000)Testing instructions
npx jest --testPathPattern treeSearchEfficiency