Conversation
Add back the InvalidLicenseStringException to the parseSPDXLicenseStringCompatV2 license signature. The previous PR removed this due to a compiler warning. The change, however, breaks compatibility (e.g. the spdx-java-spreadsheet-store no longer compiles with the signature removed). We could / should remove it in the future but it may be considered a breaking change. Not something for a patch release. Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
pmonks
approved these changes
Mar 12, 2026
Collaborator
pmonks
left a comment
pmonks
left a comment
There was a problem hiding this comment.
Yeah I saw that in the prior PR but wasn't sure if reducing the list of thrown exceptions was backwards compatibility breaking in Java or not. I guess I got my answer! 😉
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add back the InvalidLicenseStringException to the
parseSPDXLicenseStringCompatV2 license signature.
The previous PR removed this due to a compiler warning. The change, however, breaks compatibility (e.g. the spdx-java-spreadsheet-store no longer compiles with the signature removed).
We could / should remove it in the future but it may be considered a breaking change. Not something for a patch release.