Add camera-relative splat rendering support for large world coordinates#291
Open
WilliamLiu-1997 wants to merge 1 commit intosparkjsdev:v2.0.0-previewfrom
Open
Add camera-relative splat rendering support for large world coordinates#291WilliamLiu-1997 wants to merge 1 commit intosparkjsdev:v2.0.0-previewfrom
WilliamLiu-1997 wants to merge 1 commit intosparkjsdev:v2.0.0-previewfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to #287
Large-world precision: add optional camera-relative rendering path
Summary
This PR adds an optional camera-relative rendering mode for large-world scenes to reduce precision loss and make splat handling more consistent across pipeline paths.
Motivation
Several parts of the current pipeline still operate on absolute large coordinates, including generation, view-direction evaluation, depth handling, and final accumulator transforms. In large-coordinate scenes, this can lead to jitter, unstable depth/sorting, and inconsistent behavior between packed,
extSplats, andextCovSplatspaths.Changes
useRelativeCenterinsrc/SplatGenerator.tsto enable camera-relative renderingcontextin absolute-world space, while introducing internalrenderContextinsrc/SplatMesh.tsfor relative renderingcenterconsistently across packed,extSplats, andextCovSplatspaths insrc/SplatAccumulator.tsdisplay.viewOrigininsrc/SparkRenderer.tsso accumulator-to-view transforms are consistent across pathsrenderContext.worldToViewBenefits
Notes
useRelativeCenter = truegsplat.centeris always in absolute world space may need review