Open
Conversation
deluca-mike
requested review from
TheMj0ln1r,
lucas-manuel and
supercontracts
Summary by OctaneNew ContractsNo new contracts were added. Updated Contracts
🔗 Commit Hash: 55b4354 |
WalkthroughPrecision handling adjustments in a liquidity curve library. Calculation logic for swap, addLiquidity, and removeLiquidity functions updated to maintain higher-precision (36-decimal) intermediate values, with direct scaled comparisons replacing computed shortcuts and division-based adjustments. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@src/libraries/CurveLib.sol`:
- Around line 113-114: Typo in the inline comment near the CurveLib
calculations: change "nether" to "neither" in the sentence that reads
"`params.minAmountOut * rates[params.outputIndex]` and `params.amountIn *
rates[params.inputIndex]` are always to 1e36 precision, so nether side wil
overflow..."; update the wording to "neither side will overflow" and correct
"wil" to "will" so the comment referring to params.minAmountOut,
params.amountIn, rates, inputIndex, and outputIndex is grammatically correct.
- Around line 245-246: Fix the typo in the comment inside CurveLib.sol: change
"nether" to "neither" in the sentence referencing `valueMinWithdrawn` and
`params.lpBurnAmount * curvePool.get_virtual_price()` so the comment reads
"neither side will overflow for amounts less than ~$100,000,000,000 trillion."
Keep the rest of the comment unchanged and ensure punctuation/spacing remains
consistent.
- Around line 177-178: Fix the typos in the NOTE comment inside CurveLib.sol
that mentions "params.minLpAmount * curvePool.get_virtual_price()" and
"valueDeposited": change "nether" to "neither" and any instance of "wil" to
"will" so the sentence reads correctly (e.g., "so neither side will
overflow..."). Update the comment text only; do not modify logic or variable
names.
Comment on lines
+113
to
+114
| // NOTE: `params.minAmountOut * rates[params.outputIndex]` and `params.amountIn * rates[params.inputIndex]` are | ||
| // always to 1e36 precision, so nether side wil overflow for amounts less than ~$100,000,000,000 trillion. |
There was a problem hiding this comment.
Typo in comment: "nether" should be "neither".
📝 Proposed fix
- // NOTE: `params.minAmountOut * rates[params.outputIndex]` and `params.amountIn * rates[params.inputIndex]` are
- // always to 1e36 precision, so nether side wil overflow for amounts less than ~$100,000,000,000 trillion.
+ // NOTE: `params.minAmountOut * rates[params.outputIndex]` and `params.amountIn * rates[params.inputIndex]` are
+ // always to 1e36 precision, so neither side will overflow for amounts less than ~$100,000,000,000 trillion.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // NOTE: `params.minAmountOut * rates[params.outputIndex]` and `params.amountIn * rates[params.inputIndex]` are | |
| // always to 1e36 precision, so nether side wil overflow for amounts less than ~$100,000,000,000 trillion. | |
| // NOTE: `params.minAmountOut * rates[params.outputIndex]` and `params.amountIn * rates[params.inputIndex]` are | |
| // always to 1e36 precision, so neither side will overflow for amounts less than ~$100,000,000,000 trillion. |
🤖 Prompt for AI Agents
In `@src/libraries/CurveLib.sol` around lines 113 - 114, Typo in the inline
comment near the CurveLib calculations: change "nether" to "neither" in the
sentence that reads "`params.minAmountOut * rates[params.outputIndex]` and
`params.amountIn * rates[params.inputIndex]` are always to 1e36 precision, so
nether side wil overflow..."; update the wording to "neither side will overflow"
and correct "wil" to "will" so the comment referring to params.minAmountOut,
params.amountIn, rates, inputIndex, and outputIndex is grammatically correct.
Comment on lines
+177
to
+178
| // NOTE: `params.minLpAmount * curvePool.get_virtual_price()` and `valueDeposited` are always to 1e36 precision, | ||
| // so nether side will overflow for amounts less than ~$100,000,000,000 trillion. |
There was a problem hiding this comment.
Typos in comment: "nether" → "neither" and "wil" → "will".
📝 Proposed fix
- // NOTE: `params.minLpAmount * curvePool.get_virtual_price()` and `valueDeposited` are always to 1e36 precision,
- // so nether side will overflow for amounts less than ~$100,000,000,000 trillion.
+ // NOTE: `params.minLpAmount * curvePool.get_virtual_price()` and `valueDeposited` are always to 1e36 precision,
+ // so neither side will overflow for amounts less than ~$100,000,000,000 trillion.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // NOTE: `params.minLpAmount * curvePool.get_virtual_price()` and `valueDeposited` are always to 1e36 precision, | |
| // so nether side will overflow for amounts less than ~$100,000,000,000 trillion. | |
| // NOTE: `params.minLpAmount * curvePool.get_virtual_price()` and `valueDeposited` are always to 1e36 precision, | |
| // so neither side will overflow for amounts less than ~$100,000,000,000 trillion. |
🤖 Prompt for AI Agents
In `@src/libraries/CurveLib.sol` around lines 177 - 178, Fix the typos in the NOTE
comment inside CurveLib.sol that mentions "params.minLpAmount *
curvePool.get_virtual_price()" and "valueDeposited": change "nether" to
"neither" and any instance of "wil" to "will" so the sentence reads correctly
(e.g., "so neither side will overflow..."). Update the comment text only; do not
modify logic or variable names.
Comment on lines
+245
to
+246
| // NOTE: `valueMinWithdrawn` and `params.lpBurnAmount * curvePool.get_virtual_price()` are always to 1e36 | ||
| // precision, so nether side will overflow for amounts less than ~$100,000,000,000 trillion. |
There was a problem hiding this comment.
Typo in comment: "nether" should be "neither".
📝 Proposed fix
- // NOTE: `valueMinWithdrawn` and `params.lpBurnAmount * curvePool.get_virtual_price()` are always to 1e36
- // precision, so nether side will overflow for amounts less than ~$100,000,000,000 trillion.
+ // NOTE: `valueMinWithdrawn` and `params.lpBurnAmount * curvePool.get_virtual_price()` are always to 1e36
+ // precision, so neither side will overflow for amounts less than ~$100,000,000,000 trillion.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // NOTE: `valueMinWithdrawn` and `params.lpBurnAmount * curvePool.get_virtual_price()` are always to 1e36 | |
| // precision, so nether side will overflow for amounts less than ~$100,000,000,000 trillion. | |
| // NOTE: `valueMinWithdrawn` and `params.lpBurnAmount * curvePool.get_virtual_price()` are always to 1e36 | |
| // precision, so neither side will overflow for amounts less than ~$100,000,000,000 trillion. |
🤖 Prompt for AI Agents
In `@src/libraries/CurveLib.sol` around lines 245 - 246, Fix the typo in the
comment inside CurveLib.sol: change "nether" to "neither" in the sentence
referencing `valueMinWithdrawn` and `params.lpBurnAmount *
curvePool.get_virtual_price()` so the comment reads "neither side will overflow
for amounts less than ~$100,000,000,000 trillion." Keep the rest of the comment
unchanged and ensure punctuation/spacing remains consistent.
Overview
🔗 Commit Hash: 55b4354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.