WIP: Propagate trace context from Cowboy to Plug#5
Open
GregMefford wants to merge 1 commit intotrace_gatewayfrom
Open
WIP: Propagate trace context from Cowboy to Plug#5GregMefford wants to merge 1 commit intotrace_gatewayfrom
GregMefford wants to merge 1 commit intotrace_gatewayfrom
Conversation
Member
|
This looks very cool :) |
Member
|
Its interesting, I thought someone ended up implementing some code in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still WIP, but I got the basics working for using @binaryseed's
cowboy_telemetrythat was recently added toPlugCowboy. I'm hopeful that this will allow us to much more reliably capture traces for all requests, even if something crashes or exits in the Plug request process.I shoved it in this branch so that I could quickly try to get it working without having to juggle all the Spandex deps, but I think ultimately this belongs in a re-usable library instead of copy/pasted into everyone's apps.