Skip to content

Replace equivalent fmt.Sprintf calls with strconv.Itoa #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
courier-new wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace equivalent fmt.Sprintf calls with strconv.Itoa #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions logger/logger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package logger

import "testing"
import (
"testing"

import "github.com/sirupsen/logrus"
"github.com/sirupsen/logrus"
)

func TestLogLevel(t *testing.T) {
tests := map[string]logrus.Level{
Expand Down
3 changes: 2 additions & 1 deletion models/campaign_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package models

import (
"fmt"
"strconv"
"testing"
"time"

Expand Down Expand Up @@ -156,7 +157,7 @@ func setupCampaignDependencies(b *testing.B, size int) {
group := Group{Name: "Test Group"}
// Create a large group of 5000 members
for i := 0; i < size; i++ {
group.Targets = append(group.Targets, Target{BaseRecipient: BaseRecipient{Email: fmt.Sprintf("test%d@example.com", i), FirstName: "User", LastName: fmt.Sprintf("%d", i)}})
group.Targets = append(group.Targets, Target{BaseRecipient: BaseRecipient{Email: fmt.Sprintf("test%d@example.com", i), FirstName: "User", LastName: strconv.Itoa(i)}})
}
group.UserId = 1
err := PostGroup(&group)
Expand Down
5 changes: 3 additions & 2 deletions models/group_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package models

import (
"fmt"
"strconv"
"testing"

"github.com/jinzhu/gorm"
Expand Down Expand Up @@ -183,7 +184,7 @@ func benchmarkPostGroup(b *testing.B, iter, size int) {
g.Targets = append(g.Targets, Target{
BaseRecipient: BaseRecipient{
FirstName: "User",
LastName: fmt.Sprintf("%d", i),
LastName: strconv.Itoa(i),
Email: fmt.Sprintf("test-%d@test.com", i),
},
})
Expand All @@ -206,7 +207,7 @@ func benchmarkPutGroup(b *testing.B, iter, size int) {
g.Targets = append(g.Targets, Target{
BaseRecipient: BaseRecipient{
FirstName: "User",
LastName: fmt.Sprintf("%d", i),
LastName: strconv.Itoa(i),
Email: fmt.Sprintf("test-%d@test.com", i),
},
})
Expand Down