Open
Conversation
Contributor
WalkthroughA new PostHog AI dependency is added to the web package. PostHog utility functions are exported for distinct ID retrieval and client initialization. The chat model selection flow is refactored to initialize a PostHog client, retrieve a distinct ID, and apply tracing to the selected model with privacy settings. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Chat Client
participant Action as Model Selection Action
participant PostHog as PostHog Service
participant AISDK as AISDK Model
Client->>Action: Request model selection
Action->>Action: Compute model & provider options
Action->>PostHog: Initialize PostHog client
Action->>PostHog: Get distinct ID (cookie/session/API key)
Action->>AISDK: Wrap model with tracing
AISDK-->>Action: Traced model instance
Action->>Action: Apply privacy settings
Action-->>Client: Return model + providerOptions
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brendan-kellam
force-pushed
the
bkellam/posthog-ai
branch
from
5d1fd56 to
3e5b31a
Compare
Contributor
|
@brendan-kellam your pull request is missing a changelog! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/web/src/lib/posthog.ts (1)
90-110:⚠️ Potential issue | 🟡 Minor
distinctIdmay beundefinedwhen passed toposthog.capture().
tryGetPostHogDistinctId()can returnundefined, butposthog.capture()expectsdistinctIdto be astring. When no distinct ID is resolvable (no cookie, no session, no API key), this will passundefinedto the PostHog client, which could cause silent data loss or a runtime error.Consider guarding against this:
Suggested fix
const distinctId = await tryGetPostHogDistinctId(); const posthog = await createPostHogClient(); + if (!distinctId) { + return; + } + const headersList = await headers();🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/web/src/lib/posthog.ts` around lines 90 - 110, The call to posthog.capture in captureEvent currently passes distinctId which can be undefined (from tryGetPostHogDistinctId); ensure captureEvent always provides a string by adding a fallback before calling posthog.capture (e.g., const distinctIdSafe = distinctId ?? crypto.randomUUID() or a deterministic anon id using env.SOURCEBOT_INSTALL_ID) and pass distinctIdSafe to posthog.capture instead of distinctId; update references in captureEvent and keep tryGetPostHogDistinctId usage but guard its result so posthog.capture never receives undefined.
🧹 Nitpick comments (2)
packages/web/src/features/chat/actions.ts (1)
34-36: Consolidate duplicate imports from@/lib/posthog.Lines 34 and 36 both import from
@/lib/posthog. Merge them into a single import statement.Suggested fix
-import { captureEvent } from "@/lib/posthog"; -import { withTracing } from "@posthog/ai"; -import { createPostHogClient, tryGetPostHogDistinctId } from "@/lib/posthog"; +import { captureEvent, createPostHogClient, tryGetPostHogDistinctId } from "@/lib/posthog"; +import { withTracing } from "@posthog/ai";🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/web/src/features/chat/actions.ts` around lines 34 - 36, There are duplicate import lines from "@/lib/posthog"; consolidate them by replacing the two separate imports with a single import that includes captureEvent, createPostHogClient, and tryGetPostHogDistinctId together (so update the import statements that reference captureEvent and the import that references createPostHogClient/tryGetPostHogDistinctId into one unified import).packages/web/package.json (1)
66-66: Consider updating@posthog/aito the latest available version.Version
7.8.10is valid and exists on npm, but it is not current. The latest version is7.9.1, with several newer patch releases also available (7.8.11,7.8.12,7.8.13). Since the dependency specifies^7.8.10, it would automatically accept these compatible updates. Consider upgrading to7.9.1to benefit from the latest features and fixes.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/web/package.json` at line 66, Update the `@posthog/ai` dependency in package.json by replacing the current version specifier "^7.8.10" with the newer release (e.g. "7.9.1") so the project uses the latest patch/feature fixes; locate the dependency entry for "@posthog/ai" and change the version string accordingly, then run your package manager (npm/yarn/pnpm) to install and verify no breakages.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/web/src/lib/posthog.ts`:
- Around line 80-88: The code currently creates a new PostHog client on every
call of createPostHogClient (and callers like captureEvent) causing resource
leaks; change createPostHogClient to lazily initialize and return a module-level
singleton PostHog instance (e.g., keep a private let posthogInstance and
instantiate it once inside createPostHogClient if undefined), update callers
(captureEvent and any usages in actions.ts) to reuse createPostHogClient instead
of creating new clients per invocation, and add/export a shutdown function
(e.g., shutdownPostHog) that calls posthogInstance.shutdown() for graceful
teardown (also call it on process exit in initialization code or tests as
needed).
---
Outside diff comments:
In `@packages/web/src/lib/posthog.ts`:
- Around line 90-110: The call to posthog.capture in captureEvent currently
passes distinctId which can be undefined (from tryGetPostHogDistinctId); ensure
captureEvent always provides a string by adding a fallback before calling
posthog.capture (e.g., const distinctIdSafe = distinctId ?? crypto.randomUUID()
or a deterministic anon id using env.SOURCEBOT_INSTALL_ID) and pass
distinctIdSafe to posthog.capture instead of distinctId; update references in
captureEvent and keep tryGetPostHogDistinctId usage but guard its result so
posthog.capture never receives undefined.
---
Nitpick comments:
In `@packages/web/package.json`:
- Line 66: Update the `@posthog/ai` dependency in package.json by replacing the
current version specifier "^7.8.10" with the newer release (e.g. "7.9.1") so the
project uses the latest patch/feature fixes; locate the dependency entry for
"@posthog/ai" and change the version string accordingly, then run your package
manager (npm/yarn/pnpm) to install and verify no breakages.
In `@packages/web/src/features/chat/actions.ts`:
- Around line 34-36: There are duplicate import lines from "@/lib/posthog";
consolidate them by replacing the two separate imports with a single import that
includes captureEvent, createPostHogClient, and tryGetPostHogDistinctId together
(so update the import statements that reference captureEvent and the import that
references createPostHogClient/tryGetPostHogDistinctId into one unified import).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
packages/web/package.jsonpackages/web/src/features/chat/actions.tspackages/web/src/lib/posthog.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores