Merged
Conversation
Contributor
|
LGTM! Nice work! I'll start a 900s run in CPAchecker that fits the initial problem that uncovered the problem. That way we can compare it properly (i already have results for current JavaSMT |
Contributor
|
Results (w comparison to before) for the overflow category: No regressions and only 123 out-of-memories now (546 before). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this PR adds two optimizations for Bitwuzla to bring down memory usage:
Evaluatorto skip model generation inallSatextractVariablesAndUFsto avoid creating unnecessary Java proxies in the visitorHere are some results from SVCOMP with a 60s time limit: SV-COMP26_no-overflow
The left column is before this PR, the middle is with the new Evaluator, and the right is with the
extractVaraiblesAndUFsoptimization (and the Evaluator)And here's the scatter plot for a before-after comparison:
