CVC4: update CVC4 to v1.8.1-X to remove buggy finalizers (again)#642
Merged
kfriedberger merged 4 commits intomasterfrom Apr 9, 2026
Merged
CVC4: update CVC4 to v1.8.1-X to remove buggy finalizers (again)#642kfriedberger merged 4 commits intomasterfrom
kfriedberger merged 4 commits intomasterfrom
Conversation
Contributor
|
Thanks for looking into it! It's already looking a lot better. I think you can just remove the @After
public void freeEnvironment() {
smtEngine.delete();
exprMgr.delete();
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default CVC4 versions trigger random segmentation faults due to issues with Java finalizers. This PR switches to a custom build that disables them to ensure stability.
This introduces memory leaks for solver-related objects (Terms, Types, SmtEngine, ExprManager). This behavior is consistent with our last 6 years of operation and is deemed an acceptable trade-off for preventing JVM crashes.
Build source: kfriedberger/CVC4@1f9dbdc
PS: If someone wants to play around in Java, we could try to close at least SmtEngine and ExprManager once no longer needed. All objects provide the operation for
delete().