Skip to content

[charmed_mongodb] feat: Add Charmed MongoDB plugin#4278

Open
Gu1nness wants to merge 1 commit intososreport:mainfrom
Gu1nness:feat/charmed-mongodb
Open

[charmed_mongodb] feat: Add Charmed MongoDB plugin#4278
Gu1nness wants to merge 1 commit intososreport:mainfrom
Gu1nness:feat/charmed-mongodb

Conversation

@Gu1nness
Copy link
Copy Markdown

@Gu1nness Gu1nness commented Mar 31, 2026

<---
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@Gu1nness Gu1nness force-pushed the feat/charmed-mongodb branch from c3a34f6 to 231c1ac Compare March 31, 2026 08:09
@packit-as-a-service
Copy link
Copy Markdown

packit-as-a-service Bot commented Mar 31, 2026

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4278
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

pmoravec
pmoravec reviewed Mar 31, 2026
View reviewed changes
Comment thread sos/report/plugins/charmed_mongodb.py Outdated
pmoravec
pmoravec reviewed Mar 31, 2026
View reviewed changes
Comment thread sos/report/plugins/charmed_mongodb.py Outdated
pmoravec
pmoravec reviewed Mar 31, 2026
View reviewed changes
Comment thread sos/report/plugins/charmed_mongodb.py Outdated
pmoravec
pmoravec reviewed Mar 31, 2026
View reviewed changes
Comment thread sos/report/plugins/charmed_mongodb.py Outdated
pmoravec
pmoravec reviewed Mar 31, 2026
View reviewed changes
Comment thread sos/report/plugins/charmed_mongodb.py Outdated
pmoravec
pmoravec reviewed Mar 31, 2026
View reviewed changes
Comment thread sos/report/plugins/charmed_mongodb.py Outdated
pmoravec
pmoravec reviewed Mar 31, 2026
View reviewed changes
Comment thread sos/report/plugins/charmed_mongodb.py Outdated
@pmoravec
Copy link
Copy Markdown
Contributor

pmoravec commented Mar 31, 2026

Please squash the commits into one. generally ack otherwise.

@Gu1nness Gu1nness force-pushed the feat/charmed-mongodb branch from a74d847 to 1ddf249 Compare March 31, 2026 12:55
@Gu1nness
Copy link
Copy Markdown
Author

Gu1nness commented Mar 31, 2026

@pmoravec All integrated:

@Gu1nness Gu1nness requested a review from pmoravec March 31, 2026 12:59
@Gu1nness Gu1nness mentioned this pull request Apr 3, 2026
Open
6 tasks
arif-ali
arif-ali requested changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no trigger for this plugin, which means that this plugin will run on every Ubuntu system, and that doesn't make sense. Please used one of packages, files, services tuples that can help with triggering this plugin

Comment thread sos/report/plugins/charmed_mongodb.py Outdated
Comment thread sos/report/plugins/charmed_mongodb.py Outdated
@arif-ali arif-ali added Kind/Ubuntu Ubuntu related item Status/Need More Info Feedback is required to reproduce issue or to continue work Kind/Good First Issue This is a good issue for a first time contributor Kind/New plugin New plugin being added Kind/Collection New or updated command or file collection labels Apr 3, 2026
@Gu1nness
Copy link
Copy Markdown
Author

Gu1nness commented Apr 3, 2026 •
edited
Loading

There is no trigger for this plugin, which means that this plugin will run on every Ubuntu system, and that doesn't make sense. Please used one of packages, files, services tuples that can help with triggering this plugin

On VM this makes sense, but how would that be usable on kubernetes then ?
Done

@Gu1nness Gu1nness force-pushed the feat/charmed-mongodb branch 4 times, most recently from 158ec9e to 3af3419 Compare April 3, 2026 11:41
@Gu1nness Gu1nness requested a review from arif-ali April 3, 2026 11:46
@Gu1nness
Copy link
Copy Markdown
Author

Gu1nness commented Apr 15, 2026

@arif-ali Would you have time for a new review ? This one and also #4279

@arif-ali arif-ali removed the Status/Need More Info Feedback is required to reproduce issue or to continue work label Apr 21, 2026
@arif-ali arif-ali added Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Apr 21, 2026
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 21, 2026
View reviewed changes
Comment thread sos/report/plugins/charmed_mongodb.py Fixed
Comment thread sos/report/plugins/charmed_mongodb.py Fixed
@arif-ali arif-ali added Status/Need More Info Feedback is required to reproduce issue or to continue work and removed Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Apr 21, 2026
@Gu1nness Gu1nness force-pushed the feat/charmed-mongodb branch from 5e43c17 to a11631d Compare April 22, 2026 07:42
@Gu1nness
Copy link
Copy Markdown
Author

Gu1nness commented Apr 22, 2026

@arif-ali Pushed the fix for the " Suspicious unused loop iteration variable".
The other one is a false positive and can be discarded.

@arif-ali
Copy link
Copy Markdown
Member

arif-ali commented Apr 22, 2026

please resolve the flake8 and pylint tests, and rebase to main so that there is only one commit with only your changes

@Gu1nness Gu1nness force-pushed the feat/charmed-mongodb branch 3 times, most recently from 32a6be6 to b29e7d4 Compare April 22, 2026 10:37
@Gu1nness
Copy link
Copy Markdown
Author

Gu1nness commented Apr 22, 2026

@arif-ali Done.
I also improved the copy of config and logs from the containers to the host so that it would not leave any residues in the cmd_output_path.
Same done on Mongos.

@Gu1nness Gu1nness force-pushed the feat/charmed-mongodb branch from b29e7d4 to f4308cb Compare April 22, 2026 11:46
arif-ali
arif-ali reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments below

Comment thread sos/report/plugins/charmed_mongodb.py Outdated
Comment thread sos/report/plugins/charmed_mongodb.py Outdated
@Gu1nness
feat: Charmed MongoDB
b3ebee8 
This commit adds support for charmed-mongodb on both VM and Kubernetes.
It features dumping all logs, optionally some database information.
It dumps metrics exported by the mongodb_exporter tool.
It dumps journalctl information.

Signed-off-by: Neha Oudin <neha@oudin.red>
@Gu1nness Gu1nness force-pushed the feat/charmed-mongodb branch from f4308cb to b3ebee8 Compare April 22, 2026 12:36
@arif-ali arif-ali removed the Status/Need More Info Feedback is required to reproduce issue or to continue work label Apr 22, 2026
@Gu1nness Gu1nness requested a review from arif-ali April 22, 2026 12:52
@arif-ali arif-ali added Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arif-ali arif-ali arif-ali approved these changes

@pmoravec pmoravec pmoravec approved these changes

+1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Kind/Collection New or updated command or file collection Kind/Good First Issue This is a good issue for a first time contributor Kind/New plugin New plugin being added Kind/Ubuntu Ubuntu related item Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gu1nness @pmoravec @arif-ali @github-advanced-security