[cleaner] Add option to prep audit logs#4277
Conversation
|
This isnt final yet, rather asking for a feedback of the direction. IMHO we should scrub hostnames and usernames in audit logs, like I discussed in https://github.com/orgs/sosreport/discussions/4258. To prevent repetitive reading of audit logs, I hook the prepping into the main cleaner class in some way. Does this sound good to you? Should we deal with compressed audit logs - should we decompress and parse them? Even if Does this behaviour deserve a cmdline option? And if so, what default value? I feel no cmdline option is the best choice, but I think there can be different opinions and valid arguments here. I am looking for your feedback before I complete the PR (just some bits remain, functionality is there). |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Some (short) hostnames or usernames can be hidden in audit logs. Allow parsing audit logs to obfuscate this type of sensitive data. Closes: sosreport#4277 Relevant: sosreport#4258 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
1a9be8e to
4080257
Compare
|
This PR is ready for a review, though not yet for merge. Before merge, I need to know answers to #4277 (comment) to let me incorporate the feedback in the PR. Is the RFE behind the PR sane and worth implementing? |
Some (short)hostnames or usernames can be hidden in audit logs.
Allow parsing audit logs to obfuscate this type of sensitive data.
Closes: #4277
Relevant: #4258
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines