[redhat,upload] Fix issue with upload permission error due to not#4275
Merged
TurboTurtle merged 1 commit intososreport:mainfrom Apr 9, 2026
Merged
[redhat,upload] Fix issue with upload permission error due to not#4275TurboTurtle merged 1 commit intososreport:mainfrom
TurboTurtle merged 1 commit intososreport:mainfrom
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
jcastill
reviewed
Mar 25, 2026
| # already in the user directory so set user_dir to None | ||
| if user_dir: | ||
| ret.sendline('pwd') | ||
| ret.expect('sftp> ') |
Member
There was a problem hiding this comment.
Maybe it's worth adding more to the pattern, like in:
https://github.com/dwolstroRH/sos/blob/f8c2d94a3e98d86c1fb20dae58ea6b80c059a43d/sos/upload/targets/__init__.py#L523
At least adding:
pexpect.TIMEOUT,
pexpect.EOF
Member
There was a problem hiding this comment.
And perhaps also things like "command not found" or similar, in case the server doesn't support PWD
| if user_dir: | ||
| ret.sendline('pwd') | ||
| ret.expect('sftp> ') | ||
|
|
Member
There was a problem hiding this comment.
And check the result and print a message for the end user, i.e.:
pwd_expects = [
'sftp>',
'Invalid command.',
pexpect.TIMEOUT,
pexpect.EOF
]
pwd_cmd = ret.expect('sftp> ')
if pwd_cmd == 1:
self.ui_log.info(
_("The server doesn't support the PWD command")
)
Perhaps not using ui_log, it's just a suggestion.
Contributor
|
Ack up to the Jose's comments. |
switching into the user directory prior to
putting the file to the sftp directory.
Related: RHEL-52919
Signed-off-by: David Wolstromer <dwolstro@redhat.com>
f8c2d94 to
a018068
Compare
pmoravec
approved these changes
Apr 7, 2026
TurboTurtle
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: RHEL-52919
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines