[foreman_installer] Collect satellite-clone data

[pmoravec]

Collect satellite-clone related data, as a wrapper of foreman/Satellite installation with cloned data.

Closes: #4238

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname email@example.com?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
• Are all passwords or private data gathered by this PR obfuscated?

[pmoravec]

Hi @evgeni , could you please review if I haven't forgotten anything, or if the collected data cant contain some sensitive info (passwords or similar)? AFAIK no, but more eyes see more.

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo dnf install -y 'dnf*-command(copr)'
• dnf copr enable packit/sosreport-sos-4238
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[evgeni]

this can contain sensitive data

[pmoravec]

Can you show an example, please?

[evgeni]

https://github.com/RedHatSatellite/satellite-clone/blob/75531626365bcd9102c2eff00d2a663e844a81cd/satellite-clone-vars.sample.yml#L34-L45

[evgeni]

this can contain sensitive data

[pmoravec]

Ditto.

[evgeni]

output of https://github.com/RedHatSatellite/satellite-clone/blob/75531626365bcd9102c2eff00d2a663e844a81cd/roles/satellite-clone/tasks/main.yml#L40

there might be others

[evgeni]

can this be an own collector? it's not really foreman related.

[pmoravec]

can this be an own collector? it's not really foreman related.

I was considering this, so I put the collection under RedHatForemanInstaller class only. Though I agree it is independent on foreman-installer or also/even satellite-installer. On the other side I didnt want to bring a tiny plugin that would be rarely used (from the universe of all sosreports collections).

I am not against putting this into a separate plugin, I see pros and cons for both solutions. Let see for others feedback (@TurboTurtle shall have some Satellite experience as well?).

[TurboTurtle]

ack to the code.

I personally wouldn't consider activation keys as sensitive data, but I'll defer to Pavel and Evgeni on that.

@pmoravec feel free to merge after deciding the above.

edit:

I am not against putting this into a separate plugin, I see pros and cons for both solutions. Let see for others feedback (@TurboTurtle shall have some Satellite experience as well?).

Uh, no real opinion here. It'd be a small plugin indeed, and I wonder what the enablement trigger would be such that the same host wouldn't also already trigger this plugin.

[evgeni]

I think the RH Portal team considers AKs secrets.

[TurboTurtle]

I think the RH Portal team considers AKs secrets.

Ack. No pushback from me.