Fix race condition when setting mutex key#6
Open
clupprich wants to merge 3 commits intosongkick:masterfrom
Open
Fix race condition when setting mutex key#6clupprich wants to merge 3 commits intosongkick:masterfrom
clupprich wants to merge 3 commits intosongkick:masterfrom
Conversation
11.0 introduces a breaking change that removes the `#last_comment` method that rspec < 3 needs.
Author
|
Pinging @ericescalante who originally implemented the switch from memcached -> Redis in a58f6ca. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's the possibility of a race condition when we're acquiring a new mutex:
DistributedMutex.attempt_to_lockfirst checks ifcurrent_lockis nil and only then sets the mutex key. However, the command that's used there isSET, whichWe need to either use
SETNX(which is deprecated) or useSETcommand with theNXoption toI'm also setting the expiration time for the key in the same command, as we don't wanna touch that if it already exists.
Had to limit the version of Rake that can be used, as it would error with newer versions.