Open
Conversation
97522c0 to
40a3432
Compare
Owner
|
Thanks for the pull request, this looks great. However, there's a couple of small things I would like to see changed before I merge this:
The documentation is not parsed correctly by yard and has a few other issues:
Just run |
Owner
|
Also, can you please make sure that all of your code is run at least once in the tests? The coverage report ( |
Contributor
Author
|
Work in progress (docs):
|
f4e477f to
4411407
Compare
Contributor
Author
|
4411407 to
8e376b9
Compare
200186d to
153cb75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a contrib class AddAptRepo.