fix: prevent infinite loop from unexpected server response (#1898)#2083
Open
yinonburgansky wants to merge 1 commit intosolidjs:1.xfrom
Open
fix: prevent infinite loop from unexpected server response (#1898)#2083yinonburgansky wants to merge 1 commit intosolidjs:1.xfrom
yinonburgansky wants to merge 1 commit intosolidjs:1.xfrom
Conversation
) - Fix a regression introduced in SolidStart v1.3.0 that could cause an infinite loop when a server function returns unexpected response (for example, S3/XML error responses). - Prevents the browser from freezing or crashing when encountering such responses. - Add unit tests to prevent this regression from returning. - Tests exposed that serialization drains remaining chunks in the background and that async errors from that drain were not propagated to an end user error boundary/handler. Add a temporary catch-all in the test suite to suppress unhandled rejections until a proper error-propagation solution is implemented.
🦋 Changeset detectedLatest commit: b666a2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements: