Skip to content

#12 Add -v, --version option to changeset CLI and other small fixes#15

Merged
magiino merged 13 commits into
mainfrom
12-add-app-version-option-to-cli
Dec 23, 2025
Merged

#12 Add -v, --version option to changeset CLI and other small fixes#15
magiino merged 13 commits into
mainfrom
12-add-app-version-option-to-cli

Conversation

@magiino
Copy link
Copy Markdown
Contributor

@magiino magiino commented Nov 16, 2025

Issue number

#12

Changes

  • [#12] Add -v, --version option to changeset CLI and other small fixes (PR #15)
    • Replace package icon with transparent one
    • Fix MD012/no-multiple-blanks linter warning in generated changelog that was caused by two new lines at the bottom of a generated section instead of one
    • Fix MD024/no-duplicate-heading linter warning in generated changelog that was caused by duplicate headings. This ### {bumpType} Changes was replaced with this **{bumpType} Changes**:
    • Use absolute links to Markdown documents instead of relative ones, which may not work in some contexts (e.g., NuGet package page)
    • TreatWarningsAsErrors is changing code style warnings to errors, but we want to keep them as warnings
    • Remove leftover code for 'not initialized' error message and improve current 'not initialized' error message
    • Fix formatting of JSON, YML, XML and Markdown files to use 2-space indentation

Checklist

  • I have double-checked my own changes
  • I have read the Contribution Guidelines
  • Include the issue number (#xxx) in the branch name, PR title, and PR description in the Issue number section above
  • Provide a reasonable description of the PR in the Changes section
  • I have commented on the issue above and discussed the intended changes
  • All newly added code is adequately covered by tests
  • Make sure your PR is passing the CI/CD pipeline
  • The documentation was modified to reflect the changes

@magiino magiino self-assigned this Nov 16, 2025
@magiino magiino added the enhancement New feature or request label Nov 16, 2025
@magiino magiino linked an issue Nov 16, 2025 that may be closed by this pull request
@magiino magiino requested review from a team and jvilimek November 16, 2025 11:46
@magiino magiino force-pushed the 12-add-app-version-option-to-cli branch from 37359ee to 6661968 Compare November 16, 2025 12:11
Comment thread docs/commands-implementation-details.md
Comment thread CONTRIBUTING.md Outdated
Copy link
Copy Markdown
Contributor

@jvilimek jvilimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small issue found, see the comment

Co-authored-by: Jan Vilimek <jvilimek@users.noreply.github.com>
jvilimek
jvilimek previously approved these changes Dec 22, 2025
Copy link
Copy Markdown
Contributor

@jvilimek jvilimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There are still tests failing, that needs to be fixed

Failed GenerateChangelogFilesAsync_GeneratesTwoChangelogs_WhenChangelogsForMultipleProjects [3 ms]
  Error Message:
   Expected string to be the same string, but they differ on line 5 and column 1 (index 29):
             ↓ (actual)
  "…2.0.0\n\n**Major Changes**:\n\n- change2\n\n**Minor Changes**:\n\n-…"
  "…2.0.0\n\n### Major Changes\n\n- change2\n\n### Minor Changes\n\n-…"
             ↑ (expected).

@magiino magiino closed this Dec 22, 2025
@magiino magiino reopened this Dec 22, 2025
@magiino magiino force-pushed the 12-add-app-version-option-to-cli branch from aaddef7 to eba110b Compare December 22, 2025 17:57
Copy link
Copy Markdown
Contributor

@jvilimek jvilimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magiino magiino merged commit 993fd6b into main Dec 23, 2025
4 checks passed
@magiino magiino deleted the 12-add-app-version-option-to-cli branch December 23, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

Add --version command to CLI

3 participants