program: Sync native updates rent exempt reserve#132
Open
joncinque wants to merge 4 commits intosolana-program:mainfrom
Open
program: Sync native updates rent exempt reserve#132joncinque wants to merge 4 commits intosolana-program:mainfrom
joncinque wants to merge 4 commits intosolana-program:mainfrom
Conversation
#### Problem This is the p-token version of solana-program/token-2022#1006. The current rent-exempt reserve at the time of account creation is stored in the `is_native` field of a token account. When rent is decreased, or ever increased, this value will be incorrect, leading to an incorrect `amount` stored in the token account. #### Summary of changes Update `sync_native` to use the current rent-exempt reserve, and allow for the amount to potentially decrease.
febo
previously approved these changes
Feb 27, 2026
Contributor
febo
left a comment
febo
left a comment
There was a problem hiding this comment.
Looks great! Something that occurred to me is whether would be useful to add a test that uses a rent sysvar with a lower/higher lamports per byte value to simulate the situation where the minimum rent requirement changes between creation and sync.
Contributor
Author
No problem, done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is the p-token version of solana-program/token-2022#1006.
The current rent-exempt reserve at the time of account creation is stored in the
is_nativefield of a token account. When rent is decreased, or ever increased, this value will be incorrect, leading to an incorrectamountstored in the token account.Summary of changes
Update
sync_nativeto use the current rent-exempt reserve, and allow for the amount to potentially decrease.In this PR, I've also updated the old program implementation -- I'm not sure if that's needed, so I'll remove if you prefer.
I also need to ignore one of the regression fixtures since the behavior has changed.