add guidance#374
Conversation
AlexisEvan
commented
May 17, 2026
AlexisEvan
commented
Test Results24 tests 24 ✅ 2s ⏱️ Results for commit e1797aa. ♻️ This comment has been updated with latest results. |
|
| export default function GashaponMachineScreen() { | ||
| const { t } = useTranslation("notes"); | ||
| const translatedHelpSteps = t("gashapon.helpSteps", { returnObjects: true }); | ||
| const helpSteps = Array.isArray(translatedHelpSteps) |
There was a problem hiding this comment.
useTranslation("notes") means will look for the translation files in notes.json.
translatedHelpSteps means read gashapon.helpSteps from notes.json
the return type of t() is string, "helpSteps" make sure always returns an array to avoid crush
| shadowOffset: { width: 0, height: 10 }, | ||
| shadowRadius: 20, | ||
| elevation: 10, | ||
| }} |
There was a problem hiding this comment.
you can use tailwind css for this?
| <SafeAreaView className="flex-1 items-center justify-center"> | ||
| <Pressable | ||
| accessibilityRole="button" | ||
| accessibilityLabel={t("gashapon.helpButtonA11yLabel")} |
There was a problem hiding this comment.
i don't think you need accessibilityLabel
| className="absolute right-6 z-50 w-9 h-9 items-center justify-center rounded-full bg-white/90 border border-[#D6E8C7]" | ||
| style={{ top: 110 }} | ||
| > | ||
| <Text className="text-lg font-bold text-secondary">?</Text> |
There was a problem hiding this comment.
you need to use icon instead of text
| style={{ flex: 1 }} | ||
| > | ||
| <SafeAreaView className="flex-1 items-center justify-center"> | ||
| <Pressable |
There was a problem hiding this comment.
The button location is weird. You need to make it on the same line as the "Go Back" button. Please don't use absolute positioning.
| "先晃一晃手机，打乱星星顺序。", | ||
| "然后按住红色按钮，像拧瓶盖一样绕圈转动 2-3 圈。", | ||
| "听到“咔哒”声后，小门会打开。", | ||
| "最后将手机向左倾斜，机器会随机掉落一个便签,作为你接下来的任务。" |
There was a problem hiding this comment.
please check the content here 🥲 why are you using English comma in some places and Chinese comma in others.
Also, you need to tell users they need to shake their phone to the left at the same time they spin the red button.
2 participants
