refactor: improve type safety by replacing any types#366
Open
HoshinoIzumi wants to merge 11 commits into
Open
Conversation
Test Results24 tests 24 ✅ 2s ⏱️ Results for commit 1c7b634. ♻️ This comment has been updated with latest results. |
|
…ng, and sync NoteTimePickerSheet with TaskFormField schema
nxn-nicole
requested changes
May 15, 2026
| alert: null, | ||
| isDeadline: false, | ||
| deadlineDate: now, | ||
| deadlineTime: now, |
Collaborator
There was a problem hiding this comment.
any reason add these default values?
Collaborator
Author
There was a problem hiding this comment.
Since useForm<FormValues> was changed into useForm<TaskFormField>, which makes defaultvalue necessary, otherwise there will be other errors, although it is confusing when time picker sheet doesnt have anything to do with title, deadline, alert, it is a way to solve the error.
An alternative approach would be to extract a shared subset interface (e.g. TaskTimeFields) so that ReminderTab/EventTab only depend on time-related fields, avoiding coupling to unrelated fields.
…yping to FormTextInput
…abFormValues and update task mutation ID handling
…e range validation in event tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…terfaces