Open
Conversation
Owner
|
Good catch. The only place it is needed though is in the GetResponsestring. I'll make the change e when I get to work |
Author
|
I see, GetResponseStream closes the connection when the Stream closes. |
Contributor
|
The other place I can think of is ViewResult. Perhaps this should implement IDisposable and close the HttpWebResponse there. Update: Oops. I see you're modifying the Extension class and not the CouchDatabase/ViewResult. If so, I'd recommend an optional argument (e.g. public static Document GetCouchDocument(this HttpWebResponse response, bool closeResponse=true)) so the extension methods don't carry the business logic of closing the connection. |
Conflicts: LoveSeat/Support/ResponseExtensionMethods.cs
Enable CouchDatabase to use different implementation of IObjectSerializer, typically in cases were custom configuration of JsonSerializerSettings is needed.
Conflicts: LoveSeat/Interfaces/IDocumentDatabase.cs LoveSeat/Interfaces/IViewResult.cs LoveSeat/ViewOptions.cs
refactored library to make more testable/injectable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was because when the response was being read the response was not closed at the end. This meant that after 12xnumber cpu cores requests we were out of connections and just got timeouts.