Skip to content

Feature: New exciter models#402

Draft
leonardocarreras wants to merge 11 commits intosogno-platform:masterfrom
leonardocarreras:feature-exciter
Draft

Feature: New exciter models#402
leonardocarreras wants to merge 11 commits intosogno-platform:masterfrom
leonardocarreras:feature-exciter

Conversation

@leonardocarreras
Copy link
Copy Markdown
Contributor

@leonardocarreras leonardocarreras commented Aug 29, 2025

This is based on various PRs from @martinmoraga at the times of his work on ACS.

Adaptations are mine.

Ongoing work.

New models:

  • Add Model: Exciter DC1
  • Add Model: Exciter DC1 Simplified > Replaces old Exciter (.h & .cpp)
  • Add Model: Exciter DC1 Simplified for sT1
  • Add Model: Exciter DC1 Static

Updates

  • Add Base Exciter model
  • Add models to Factory
  • Add models to Component list
  • Update Generator models to the new Exciters
  • Keep a deprecated interface for backwards compatibility in generators
  • Update existing C++ examples
  • Update python bindings
  • Update notebook examples

Other

  • Fix logger (fmt related) for handling new exciter

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
@leonardocarreras leonardocarreras self-assigned this Dec 17, 2025
@leonardocarreras leonardocarreras added the enhancement New feature or request label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant