Windows: build with pybind and add workflow for wheels#392
Windows: build with pybind and add workflow for wheels#392leonardocarreras wants to merge 12 commits intomasterfrom
Conversation
9b4ce6a to
bbbc721
Compare
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
bbbc721 to
5e3f641
Compare
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
|
|
Thanks for this great initiative :) Is there a motivation why you dont you cibuildwheel as we already use it for the Linux wheels: I am strong for using it, as this will limit our maintenance burden in the long run as cibuildwheel is an officil project of the Python Packaging Authority (PyPA). Also, it would allow us to build Wheels for more platforms like MacOS and automatically for more Python versions & interpreters. |
|
Ideally, we use the existing GitHub actions workflow and extend it with a build matrix for more platforms. |
|
Hi @stv0g Maybe there are two different things in this PR, they can be split if needed. One is just about being able to compile in Windows with pybind, which is now possible after some changes. The other is the cibuildwheel, that I actually did it in a new file dpsim/.github/workflows/publish_to_pypi_win.yaml Lines 69 to 77 in f1b3989 I did not know exactly how to join the linux and windows ones together (the way to create the matrix is a bit more convoluted), probably something like this is needed |
|
Lets say that I can try to find some more time (or some more help) to make it cleaner in the next weeks, but for the moment the good news is that it works on windows (I tested locally with VS2022 too). |
|
Sorry I missed the CI build wheel part. I will have another and closer look. |



This is an initial test to build windows wheels, following the idea in #368
This PR does:
Additionally, to make this possible: