MPT-18902 E2E API client exception with the seller tests

[alephsur]

https://softwareone.atlassian.net/wiki/spaces/mpt/pages/5243175002/Seller+Object

Closes MPT-18902

• tests/e2e/accounts/conftest.py: currencies fixture now returns a list of currency objects (dicts with keys value, billingEnabled, isDefault) instead of a simple list of strings.
• tests/e2e/accounts/sellers/conftest.py: seller_factory's inner _seller sets the seller dictionary key "currency" (singular) to the provided currencies value; the factory parameter remains named currencies but the returned data shape changed from a "currencies" key to "currency" containing the structured list.
• No changes to fixture names or function signatures; only the returned data structures were modified.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: d45bbd8c-b868-43d7-9c9a-d879d82132ed

📥 Commits

Reviewing files that changed from the base of the PR and between 7926ba8 and 72838dc.

📒 Files selected for processing (2)

• tests/e2e/accounts/conftest.py
• tests/e2e/accounts/sellers/conftest.py

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/e2e/accounts/conftest.py

---

📝 Walkthrough

Walkthrough

Updated test fixtures' data shapes: tests/e2e/accounts/conftest.py now returns a list of currency objects (dicts with value, billingEnabled, isDefault), and tests/e2e/accounts/sellers/conftest.py's seller_factory inner _seller now uses the key "currency" instead of "currencies".

Changes

Cohort / File(s)	Summary
Accounts currencies fixture tests/e2e/accounts/conftest.py	Replaced a simple list of currency strings (e.g., ["USD","EUR"]) with a list of currency dictionaries containing value, billingEnabled, and isDefault. Order in returned list changed (e.g., {"value":"EUR",...} before {"value":"USD",...}).
Seller fixture key update tests/e2e/accounts/sellers/conftest.py	Adjusted seller_factory's inner _seller return shape: renamed key currencies → currency in the returned seller dict to match the updated currency data shape.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Jira Issue Key In Title	✅ Passed	The PR title contains exactly one Jira issue key in the correct format MPT-18902.
Test Coverage Required	✅ Passed	PR modifies only test fixture files in tests/e2e/accounts/ without changing any non-test code.
Single Commit Required	✅ Passed	The PR contains exactly one commit (72838dc: MPT-18902 E2E API client exception with the seller tests). Both file changes are part of this single commit.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[d3rky]

I'll DM you, have doupts on it

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/e2e/accounts/conftest.py`:
- Around line 26-37: The returned fixture list literal is missing trailing
commas which causes ruff format to rewrite it; update the list and each dict
inside to include trailing commas after the last key/value pairs and after each
dict element (e.g., add commas after False and True values and after each dict
closing brace) so the literal is ruff-friendly, then run ruff format to verify;
look for the return value in the fixture in conftest.py to apply the change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: d258c936-f18e-4251-af8f-3c062f67a49a

📥 Commits

Reviewing files that changed from the base of the PR and between 463c3ae and 7926ba8.

📒 Files selected for processing (2)

• tests/e2e/accounts/conftest.py
• tests/e2e/accounts/sellers/conftest.py

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/e2e/accounts/sellers/conftest.py

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud