Merged
Conversation
msluszniak
requested changes
Mar 27, 2026
Member
msluszniak
left a comment
msluszniak
left a comment
There was a problem hiding this comment.
Please fix the lint. Also are there any instructions how to test this feature?
mkopcins
force-pushed
the
@mkopcins/emulator_detection
branch
2 times, most recently
from
7fc1cf7 to
1c3b584
Compare
msluszniak
reviewed
Mar 27, 2026
packages/react-native-executorch/android/src/main/cpp/EmulatorDetection.h
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/android/src/main/cpp/EmulatorDetection.h
Outdated
Show resolved
Hide resolved
mkopcins
force-pushed
the
@mkopcins/emulator_detection
branch
from
1c3b584 to
e8a45ee
Compare
mkopcins
force-pushed
the
@mkopcins/emulator_detection
branch
from
e8a45ee to
a82516f
Compare
msluszniak
reviewed
Mar 27, 2026
packages/react-native-executorch/android/src/main/cpp/EmulatorDetection.h
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/android/src/main/cpp/EmulatorDetection.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
msluszniak
approved these changes
Mar 27, 2026
Member
msluszniak
left a comment
msluszniak
left a comment
There was a problem hiding this comment.
Tested using provided instructions and worked as expected :))
msluszniak
reviewed
Mar 27, 2026
packages/react-native-executorch/src/constants/resourceFetcher.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
mkopcins
added a commit
that referenced
this pull request
Mar 27, 2026
Added emulator/simulator detection for logging purposes
- [ ] Yes
- [x] No
- [ ] Bug fix (change which fixes an issue)
- [x] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [ ] Other (chores, tests, code style improvements etc.)
- [x] iOS
- [x] Android
1. Launch any example app (i.e. apps/computer-vision)
2. Connect to Ru machine via ssh, then `cd telemetry && docker compose
logs --follow api`
3. Download any model (make sure the model is not currently downloaded)
4. You should see a log looking something like this:
```
api-1 | /downloads {
api-1 | modelName: 'efficientnet-v2-s-quantized',
api-1 | countryCode: 'US',
api-1 | isEmulator: true,
api-1 | libVersion: '0.9.0'
api-1 | }
```
<!-- Add screenshots here, if applicable -->
<!-- Link related issues here using #issue-number -->
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings
<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->
---------
Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
mkopcins
added a commit
that referenced
this pull request
Mar 27, 2026
Added emulator/simulator detection for logging purposes
- [ ] Yes
- [x] No
- [ ] Bug fix (change which fixes an issue)
- [x] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [ ] Other (chores, tests, code style improvements etc.)
- [x] iOS
- [x] Android
1. Launch any example app (i.e. apps/computer-vision)
2. Connect to Ru machine via ssh, then `cd telemetry && docker compose
logs --follow api`
3. Download any model (make sure the model is not currently downloaded)
4. You should see a log looking something like this:
```
api-1 | /downloads {
api-1 | modelName: 'efficientnet-v2-s-quantized',
api-1 | countryCode: 'US',
api-1 | isEmulator: true,
api-1 | libVersion: '0.9.0'
api-1 | }
```
<!-- Add screenshots here, if applicable -->
<!-- Link related issues here using #issue-number -->
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings
<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->
---------
Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added emulator/simulator detection for logging purposes
Introduces a breaking change?
Type of change
Tested on
Testing instructions
cd telemetry && docker compose logs --follow apiScreenshots
Related issues
Checklist
Additional notes