feat: Added tracking downloads on our infrastructure#1019
Open
mkopcins wants to merge 1 commit intorelease/0.7from
Open
feat: Added tracking downloads on our infrastructure#1019mkopcins wants to merge 1 commit intorelease/0.7from
mkopcins wants to merge 1 commit intorelease/0.7from
Conversation
chmjkb
reviewed
Mar 27, 2026
Comment on lines
237
to
+507
| @@ -503,6 +504,7 @@ export class ResourceFetcher { | |||
| to: sourceExtended.fileUri, | |||
| }); | |||
| this.downloads.delete(source); | |||
| ResourceFetcherUtils.triggerDownloadEvent(uri); | |||
Collaborator
There was a problem hiding this comment.
Why are we doing this twice with different URIs 🤔?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Like in version 0.8 added downloads tracking.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes