Skip to content

Improve GC compaction support and write barriers in WorkerPool #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuel-williams-shopify merged 1 commit into from
May 12, 2026
Merged

Improve GC compaction support and write barriers in WorkerPool #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions ext/io/event/worker_pool.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,20 @@ static void worker_pool_mark(void *ptr)
struct IO_Event_WorkerPool *pool = (struct IO_Event_WorkerPool *)ptr;
struct IO_Event_WorkerPool_Worker *worker = pool->workers;
while (worker) {
struct IO_Event_WorkerPool_Worker *next = worker->next;
// We need to mark the thread even though its marked through the VM's ractors because we call `join`
// on them after their completion. They could be freed by then.
rb_gc_mark(worker->thread); // thread objects are currently pinned anyway
worker = next;
rb_gc_mark_movable(worker->thread);
worker = worker->next;
}
}

static void worker_pool_compact(void *ptr)
{
struct IO_Event_WorkerPool *pool = (struct IO_Event_WorkerPool *)ptr;
struct IO_Event_WorkerPool_Worker *worker = pool->workers;
while (worker) {
worker->thread = rb_gc_location(worker->thread);
worker = worker->next;
}
}

Expand All @@ -107,8 +116,8 @@ static size_t worker_pool_size(const void *ptr) {
// Ruby TypedData structures
static const rb_data_type_t IO_Event_WorkerPool_type = {
"IO::Event::WorkerPool",
{worker_pool_mark, worker_pool_free, worker_pool_size,},
0, 0, RUBY_TYPED_FREE_IMMEDIATELY
{worker_pool_mark, worker_pool_free, worker_pool_size, worker_pool_compact},
0, 0, RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED
};

// Helper function to enqueue work (must be called with mutex held)
Expand Down
Loading