Skip to content

Fix py-windows-latest-64-cores-3.14-gcp worker thread overflow #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-mayliu merged 1 commit into from
May 11, 2026
+11 −2
Merged

Fix py-windows-latest-64-cores-3.14-gcp worker thread overflow #4222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ jobs:
- python-version: "3.14"
cloud-provider: gcp
os: windows-latest-64-cores
# Cap pytest-xdist parallelism — Python 3.14 + Windows 64-core runners
# exhaust threads/memory at -n logical (MemoryError in pytest_timeout
# Timer.start, plus stack overflows in connector ThreadPoolExecutors).
tox-extra-factors: "-lowparallel"
steps:
- name: Checkout Code
uses: actions/checkout@v4
Expand Down Expand Up @@ -189,12 +193,13 @@ jobs:
# do not run other tests for macos
- if: ${{ matrix.os != 'macos-latest' }}
name: Run tests (excluding doctests)
run: python -m tox -e "py${PYTHON_VERSION/\./}-notdoctest-ci"
run: python -m tox -e "py${PYTHON_VERSION/\./}-notdoctest${EXTRA_TOX_FACTORS}-ci"
env:
PYTHON_VERSION: ${{ matrix.python-version }}
cloud_provider: ${{ matrix.cloud-provider }}
PYTEST_ADDOPTS: --color=yes --tb=short
TOX_PARALLEL_NO_SPINNER: 1
EXTRA_TOX_FACTORS: ${{ matrix.tox-extra-factors }}
SNOWPARK_PYTHON_API_TEST_BUCKET_PATH: ${{ secrets.SNOWPARK_PYTHON_API_TEST_BUCKET_PATH }}
SNOWPARK_PYTHON_API_S3_STORAGE_INTEGRATION: ${{ vars.SNOWPARK_PYTHON_API_S3_STORAGE_INTEGRATION }}
shell: bash
Expand Down
6 changes: 5 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,12 @@ setenv =
# For AST tests, use just 36 cores, because using more cores sometimes
# causes the test job to fail with exit code 143, which supposedly means
# that it uses too many machine resources.
!doctest-!ast: SNOWFLAKE_PYTEST_PARALLELISM = -n logical
!doctest-!ast-!lowparallel: SNOWFLAKE_PYTEST_PARALLELISM = -n logical
ast: SNOWFLAKE_PYTEST_PARALLELISM = -n 36
# Python 3.14 + Windows 64-core runners hit MemoryError in pytest_timeout's
# Timer.start() and thread-pool stack overflows when running 64 xdist workers,
# so cap parallelism the same way ast tests do.
lowparallel: SNOWFLAKE_PYTEST_PARALLELISM = -n 36
# Snowpark uses 4 workers for daily testing since some of its test jobs use weak MacOS instances.
!doctest: SNOWFLAKE_PYTEST_DAILY_PARALLELISM = -n 6
# Set test type, either notset, unit, integ, or both
Expand Down
Loading