SNOW-3494628: Fix indeterministic error reporting for async job no_result#4221
Open
sfc-gh-mayliu wants to merge 1 commit intomainfrom
Open
SNOW-3494628: Fix indeterministic error reporting for async job no_result#4221sfc-gh-mayliu wants to merge 1 commit intomainfrom
sfc-gh-mayliu wants to merge 1 commit intomainfrom
Conversation
sfc-gh-joshi
approved these changes
May 8, 2026
sfc-gh-yuwang
approved these changes
May 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4221 +/- ##
==========================================
- Coverage 95.04% 94.80% -0.25%
==========================================
Files 171 171
Lines 43876 43877 +1
Branches 7525 7525
==========================================
- Hits 41701 41596 -105
- Misses 1368 1435 +67
- Partials 807 846 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3494628
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Fix
AsyncJob.result("no_result")silently returning None for failed queries. The root cause is a race condition:is_still_running(status)returns False for both SUCCESS and every terminal failure state, andNO_RESULTis the only result type that doesn't trigger the prefetch hook to surface the failure later, so a failure that wasn't visible at the upfront synchronous status check would silently fall through.Repro steps:
Without the fix,
silent_noneindeterministically returns 6/30 silent failures, exact number varies from run-to-run.