Skip to content

SNOW-3338458: Snowpark python support for WIF secret in EA#4202

Open
sfc-gh-tmehta wants to merge 2 commits intomainfrom
tmehta-SNOW-3338458-snowpark-py-wif-changes
Open

SNOW-3338458: Snowpark python support for WIF secret in EA#4202
sfc-gh-tmehta wants to merge 2 commits intomainfrom
tmehta-SNOW-3338458-snowpark-py-wif-changes

Conversation

@sfc-gh-tmehta
Copy link
Copy Markdown

@sfc-gh-tmehta sfc-gh-tmehta commented Apr 27, 2026

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-3338458

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.31%. Comparing base (e7c3d2e) to head (9f27de7).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/snowflake/snowpark/secrets.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4202      +/-   ##
==========================================
+ Coverage   95.16%   95.31%   +0.14%     
==========================================
  Files         171      171              
  Lines       43788    43885      +97     
  Branches     7503     7525      +22     
==========================================
+ Hits        41672    41829     +157     
+ Misses       1294     1260      -34     
+ Partials      822      796      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-tmehta
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-tmehta sfc-gh-tmehta marked this pull request as ready for review May 6, 2026 22:54
@sfc-gh-tmehta sfc-gh-tmehta requested review from a team as code owners May 6, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants