Add Symfony 8 compatibility for http-client#1
Conversation
Widen symfony/http-client constraint from ^7.0 to ^7.0 || ^8.0 to support both Symfony 7 and Symfony 8. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces official support for Symfony 8 within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the composer.json file to add support for Symfony 8 by widening the version constraint for the symfony/http-client package to ^7.0 || ^8.0. This change is correct and aligns with the goal of supporting both Symfony 7 and 8. The change is straightforward and I have no further feedback.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Thank you @mwansinck! |
@smnandre Could you tag a new version? |
|
@mwansinck I did release the 1.0.0 yesteraday, maybe just after your message. Thx again! |
Summary
symfony/http-clientconstraint from^7.0to^7.0 || ^8.0to support both Symfony 7 and Symfony 8Test plan
composer updateresolves successfully with Symfony 8.0 packages🤖 Generated with Claude Code