Skip to content

Add Symfony 8 compatibility for http-client#1

Merged
smnandre merged 1 commit intosmnandre:mainfrom
mwansinck:upgrade-symfony-8-compat
Mar 20, 2026
Merged

Add Symfony 8 compatibility for http-client#1
smnandre merged 1 commit intosmnandre:mainfrom
mwansinck:upgrade-symfony-8-compat

Conversation

@mwansinck
Copy link
Contributor

Summary

  • Widen symfony/http-client constraint from ^7.0 to ^7.0 || ^8.0 to support both Symfony 7 and Symfony 8
  • All 54 existing tests pass with Symfony 8 dependencies

Test plan

  • composer update resolves successfully with Symfony 8.0 packages
  • All 54 tests pass (120 assertions) with no compatibility issues

🤖 Generated with Claude Code

Widen symfony/http-client constraint from ^7.0 to ^7.0 || ^8.0
to support both Symfony 7 and Symfony 8.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces official support for Symfony 8 within the http-client component. By updating the dependency constraint, it allows projects to seamlessly upgrade their Symfony framework version while maintaining full functionality and stability with this component, ensuring broader compatibility and future-proofing.

Highlights

  • Symfony 8 Compatibility: The symfony/http-client dependency constraint has been widened from ^7.0 to ^7.0 || ^8.0 to ensure compatibility with both Symfony 7 and Symfony 8.
  • Test Verification: All 54 existing tests passed successfully with Symfony 8 dependencies, confirming no compatibility issues or regressions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the composer.json file to add support for Symfony 8 by widening the version constraint for the symfony/http-client package to ^7.0 || ^8.0. This change is correct and aligns with the goal of supporting both Symfony 7 and 8. The change is straightforward and I have no further feedback.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@smnandre
Copy link
Owner

Thank you @mwansinck!

@smnandre smnandre merged commit 60151ef into smnandre:main Mar 20, 2026
2 of 4 checks passed
@mwansinck
Copy link
Contributor Author

Thank you @mwansinck!

@smnandre Could you tag a new version?

@smnandre
Copy link
Owner

@mwansinck I did release the 1.0.0 yesteraday, maybe just after your message. Thx again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants