Open
Conversation
mtdowling
force-pushed
the
add-select-endpoint-reg
branch
2 times, most recently
from
8a4a26c to
c9cf3c3
Compare
Optimizes a couple hot instructions for S3 endpoints, but is a generic optimization. For S3, these are optimized: ``` _s3e_fips = ite(UseFIPS, "-fips", "") _s3e_ds = ite(UseDualStack, ".dualstack", "") ``` Without SELECT_BOOL_REG, each compiles to 5 opcodes: ``` LOAD_REGISTER UseFIPS JMP_IF_FALSE 5 LOAD_CONST "-fips" JUMP 2 LOAD_CONST "" ``` With SELECT_BOOL_REG, each becomes 1 opcode: ``` SELECT_BOOL_REG UseFIPS, "-fips", "" ``` The end result is that this speeds up S3 endpoint resolution consistently by 1-4% depending on the test case (smaller programs like vanilla endpoint resolution see bigger savings, larger programs see less savings).
mtdowling
force-pushed
the
add-select-endpoint-reg
branch
from
c9cf3c3 to
ecb1af7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fused SELECT_BOOL_REG to endpoints VM
Optimizes a couple hot instructions for S3 endpoints, but is a generic
optimization.
For S3, these are optimized:
Without SELECT_BOOL_REG, each compiles to 5 opcodes:
With SELECT_BOOL_REG, each becomes 1 opcode:
The end result is that this speeds up S3 endpoint resolution
consistently by 1-4% depending on the test case (smaller programs like
vanilla endpoint resolution see bigger savings, larger programs see
less savings).
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.