Skip to content

Make input/output structs implement closeable when these have streaming members#1138

Merged
sugmanue merged 3 commits intosmithy-lang:mainfrom
sugmanue:sugmanue/add-closeable-when-needed
Apr 6, 2026
Merged

Make input/output structs implement closeable when these have streaming members#1138
sugmanue merged 3 commits intosmithy-lang:mainfrom
sugmanue:sugmanue/add-closeable-when-needed

Conversation

@sugmanue
Copy link
Copy Markdown
Contributor

@sugmanue sugmanue commented Apr 4, 2026

Issue #, if available:

Description of changes:

Make input/output structs implement Closeable when these have streaming members. E.g.,

    /**
     * Closes the underlying event stream.
     */
    @Override
    public void close() {
        if (stream != null) {
            stream.close();
        }
    }

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sugmanue sugmanue merged commit b789f0e into smithy-lang:main Apr 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants