Added IPv6 support, added none auth method, added curl options#239
Closed
GJSBRT wants to merge 1 commit intosmi2:masterfrom
Closed
Added IPv6 support, added none auth method, added curl options#239GJSBRT wants to merge 1 commit intosmi2:masterfrom
GJSBRT wants to merge 1 commit intosmi2:masterfrom
Conversation
isublimity
added a commit
that referenced
this pull request
Apr 3, 2026
- IPv6: getUri() wraps bare IPv6 addresses in brackets (e.g. [::1]:8123) - AUTH_METHOD_NONE (0): skip authentication for trusted/proxy setups - curl_options: pass arbitrary CURLOPT_* via config or setCurlOptions() - CurlerRequest::option() made public for curl option injection - Tests: IPv6UriTest, AuthMethodNoneTest, CurlOptionsTest Inspired by PR #239, reimplemented with proper IPv6 detection and tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks for the idea @GJSBRT! We've reimplemented all three features from this PR with proper IPv6 detection, tests, and cleaner separation:
See the replacement PR that covers all of this. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.