Fix file upload to read contents for BigQuery credentials#28
Merged
Conversation
The file input (used by BigQuery keyFile upload) was storing Ant Design UploadFile objects as the form value. These aren't JSON-serializable, causing GraphQL "Unexpected 45 while parsing number literal" errors and cascading failures (missing datasource ID, null sql_credentials). Now uses FileReader.readAsText() to store the actual file contents as a string, which is what the backend's prepareDbParams expects to JSON.parse. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
doktorhelgi
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unexpected 45 while parsing number literalbecause the file upload stored raw Ant DesignUploadFileobjects instead of reading file contentsFileReader.readAsText()to store the actual JSON string as the form valuesql_credentials, failed test connectionTest plan
🤖 Generated with Claude Code