added Jaccard distance#358
Conversation
|
thanks. i will review this as soon as possible |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## development #358 +/- ##
===============================================
- Coverage 45.59% 44.30% -1.29%
===============================================
Files 93 95 +2
Lines 8034 8001 -33
===============================================
- Hits 3663 3545 -118
- Misses 4371 4456 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
please run |
|
Done. Pls, note, the errors encountered in already existed files, so I updated the code, which was already present. |
|
thanks! please add one or two tests and it is good to go 👍🏼 |
|
Thank you. I will merge as soon as tests pass. It will be packaged in the next release. |
Hi guys!
My first PR to your library. I added Jaccard distance. Everything is done carefully in accordance to the best development practices.
Checklist
Current behaviour
there is no jaccard distance!
New expected behaviour
now there IS the jaccard distance functionality in the library. Done with respect to the current API, and checked using a smass binary outside of the code.
Change logs
Added
Jaccard distance