Skip to content

added Jaccard distance#358

Merged
Mec-iS merged 3 commits intosmartcorelib:developmentfrom
skywardfire1:development
Mar 10, 2026
Merged

added Jaccard distance#358
Mec-iS merged 3 commits intosmartcorelib:developmentfrom
skywardfire1:development

Conversation

@skywardfire1
Copy link
Contributor

Hi guys!

My first PR to your library. I added Jaccard distance. Everything is done carefully in accordance to the best development practices.

Checklist

  • [ YES ] My branch is up-to-date with development branch.
  • [ YES ] Everything works and tested on latest stable Rust.
  • [ YES, via neural network ] Coverage and Linting have been applied

Current behaviour

there is no jaccard distance!

New expected behaviour

now there IS the jaccard distance functionality in the library. Done with respect to the current API, and checked using a smass binary outside of the code.

Change logs

Added

Jaccard distance

@skywardfire1 skywardfire1 requested a review from Mec-iS as a code owner March 8, 2026 18:41
@Mec-iS
Copy link
Collaborator

Mec-iS commented Mar 8, 2026

thanks. i will review this as soon as possible

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 27.65957% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.30%. Comparing base (70d8a0f) to head (ff65a08).
⚠️ Report is 10 commits behind head on development.

Files with missing lines Patch % Lines
src/metrics/distance/jaccard.rs 26.31% 14 Missing ⚠️
src/ensemble/random_forest_classifier.rs 28.57% 10 Missing ⚠️
src/ensemble/base_forest_regressor.rs 33.33% 8 Missing ⚠️
src/metrics/distance/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #358      +/-   ##
===============================================
- Coverage        45.59%   44.30%   -1.29%     
===============================================
  Files               93       95       +2     
  Lines             8034     8001      -33     
===============================================
- Hits              3663     3545     -118     
- Misses            4371     4456      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mec-iS
Copy link
Collaborator

Mec-iS commented Mar 9, 2026

please run clippy with the right flags and fix the errors: https://github.com/smartcorelib/smartcore/actions/runs/22827368229/job/66322459263#step:6:1

@skywardfire1
Copy link
Contributor Author

skywardfire1 commented Mar 10, 2026

Done. Pls, note, the errors encountered in already existed files, so I updated the code, which was already present.

@Mec-iS
Copy link
Collaborator

Mec-iS commented Mar 10, 2026

thanks! please add one or two tests and it is good to go 👍🏼

@Mec-iS
Copy link
Collaborator

Mec-iS commented Mar 10, 2026

Thank you. I will merge as soon as tests pass. It will be packaged in the next release.

@Mec-iS Mec-iS merged commit c77781b into smartcorelib:development Mar 10, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants