This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Fix endpoint for triggering job run on chainlink#158
Open
hossam-magdy wants to merge 2 commits intosmartcontractkit:masterfrom
Open
Fix endpoint for triggering job run on chainlink#158hossam-magdy wants to merge 2 commits intosmartcontractkit:masterfrom
hossam-magdy wants to merge 2 commits intosmartcontractkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the correct endpoint for triggering job on chainlink node is:
POST /v2/jobs/%s/runs(instead ofPOST /v2/specs/%s/runs). (Perhaps the*/specs/*one was in a previous chainlink versions?)Refs: Chainlink v1.0.0 router code, and docs
Also:
GET /v2/jobs(instead ofGET /v2/specs)POST /v2/jobs(instead ofPOST /v2/specs)Ref: https://github.com/smartcontractkit/chainlink/blob/v1.0.0/core/web/router.go/#L283-L286
Or maybe I missed something and the
*/specs/*endpoints are meant to be the correct ones, in that case please feel free to close the PR.