Skip to content

migrate gateway http capability limits#21430

Merged
jinhoonbang merged 8 commits intodevelopfrom
CRE-1798-migrate-cre-gateway-limitters-to-limits-library
Mar 10, 2026
Merged

migrate gateway http capability limits#21430
jinhoonbang merged 8 commits intodevelopfrom
CRE-1798-migrate-cre-gateway-limitters-to-limits-library

Conversation

@jinhoonbang
Copy link
Copy Markdown
Contributor

@jinhoonbang jinhoonbang commented Mar 5, 2026 •
edited
Loading

-Replaced the ratelimit package dependency with two chainlink-common limits library fields (globalNodeRateLimiter, perNodeRateLimiter) on gatewayHandler for HTTP capabilities

@jinhoonbang jinhoonbang requested review from a team as code owners March 5, 2026 21:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

👋 jinhoonbang, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026 •
edited
Loading

✅ No conflicts with other open PRs targeting develop

@jinhoonbang jinhoonbang requested a review from a team as a code owner March 5, 2026 21:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026 •
edited
Loading

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Mar 5, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@jinhoonbang jinhoonbang requested review from ettec and jmank88 March 6, 2026 00:42
ettec
ettec requested changes Mar 6, 2026
View reviewed changes
Comment thread core/services/gateway/handlers/capabilities/v2/http_handler.go Outdated
@jmank88 jmank88 mentioned this pull request Mar 6, 2026
Merged
jmank88
jmank88 reviewed Mar 6, 2026
View reviewed changes
Comment thread core/services/gateway/handlers/capabilities/v2/http_handler.go
ettec
ettec previously approved these changes Mar 9, 2026
View reviewed changes
@jinhoonbang jinhoonbang requested a review from ettec March 9, 2026 20:39
@jinhoonbang jinhoonbang requested a review from jmank88 March 9, 2026 20:39
@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented Mar 9, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jinhoonbang jinhoonbang enabled auto-merge March 10, 2026 02:07
@jinhoonbang jinhoonbang added this pull request to the merge queue Mar 10, 2026
Merged via the queue into develop with commit 2e95f8b Mar 10, 2026
269 of 291 checks passed
@jinhoonbang jinhoonbang deleted the CRE-1798-migrate-cre-gateway-limitters-to-limits-library branch March 10, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes

@ettec ettec ettec approved these changes

@DimitriosNaikopoulos DimitriosNaikopoulos Awaiting requested review from DimitriosNaikopoulos

@bolekk bolekk Awaiting requested review from bolekk

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

@ChrisAmora ChrisAmora Awaiting requested review from ChrisAmora

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jinhoonbang @jmank88 @ettec