Merged
Conversation
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new CRE settings key intended to control trigger registration status update timing, with corresponding defaults and documentation updates.
Changes:
- Introduce
TriggerRegistrationStatusUpdateTimeoutin CRE settings schema andDefault. - Add the new key to
defaults.jsonanddefaults.toml. - Document the new key in the README flowchart.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| pkg/settings/cresettings/settings.go | Adds the new settings field and default value in the schema. |
| pkg/settings/cresettings/defaults.toml | Adds a default value for the new setting in TOML defaults. |
| pkg/settings/cresettings/defaults.json | Adds a default value for the new setting in JSON defaults. |
| pkg/settings/cresettings/README.md | Adds the new key to the settings flowchart documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ettec
force-pushed
the
d2d-trigger-status-timeout-setting
branch
from
bd7a450 to
bad99ec
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 0649ffb | Previous: eddb368 | Ratio |
|---|---|---|---|
BenchmarkKeystore_Sign/nop/in-process |
766.8 ns/op |
381.5 ns/op |
2.01 |
This comment was automatically generated by workflow using github-action-benchmark.
ettec
force-pushed
the
d2d-trigger-status-timeout-setting
branch
from
0649ffb to
3cc81a8
Compare
cedric-cordenier
approved these changes
Mar 6, 2026
george-dorin
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of this PR-> smartcontractkit/chainlink#20973