feat: add an option to display driver names instead of TLAs#271
feat: add an option to display driver names instead of TLAs#271r4ai wants to merge 3 commits intoslowlydev:developfrom
Conversation
|
@r4ai is attempting to deploy a commit to the f1-dash Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@slowlydev Thank you for the review!
When you say the current implementation isn't optimal, do you mean that the issue lies not in the design but in the choice of component? If that's the case, I thought it might be better to create a new Also, regarding the design, I personally felt that when displaying driver names, it might be better to use a sans-serif font rather than a monospaced one.
I fixed it in 5687e2c |
|
A bit of design because it's just the driver tag which doesn't really look good with the full name, the amount of white, and the spacing. Maybe we would show the full name on two rows + the position. Also, yes, a sans-serif would probably look better, and all of that could maybe be done in a different component. |

close #270
Changes
This PR mainly does the following:
If you feel this feature isn’t needed, feel free to close the PR.
Notes
All this PR does is add an option on settings page; the default presentation remains unchanged.
What to Review
To display drivers’ names on the dashboard, the CSS used for the
LeaderBoardlayout has been switched from Flexbox + Grid to Subgrid. Because this is a relatively large change, there may be unintended layout issues elsewhere. Also, some margins and spacing differ slightly from the current design, so please confirm whether those differences are acceptable.Screenshots of the App
When driver names are shown:
When driver TLAs are shown: