Not found errors raised by id_for use more specific error classes when they exist

[eizengan]

Problem

Presently the id_for method always raises a SlackError. This means that when calling e.g. users_info one must handle both UserNotFound and SlackError-with-a-message-equal-"user_not_found" to actually cover ones bases.

Solution

This uses the existing error type deduction mechanism to raise a more specific error when one exists. At the time of writing this will work for all consumers of id_for

Potential issues

The specific errors are subclasses of SlackError, and therefore will still behave as expected in existing rescues, is_a? calls, etc. Any class equality checks failing to account for inheritance, however, will break.

[github-actions]

Danger Report

No issues found.

View run

[dblock]

LGTM, thank you! Let's add a section to UPGRADING and bump the version to 3.2.0 since it's not a minor change.

It looks backwards compatible since NotFound errors are also SlackError's? Check?

[eizengan]

LGTM, thank you! Let's add a section to UPGRADING and bump the version to 3.2.0 since it's not a minor change.

Sounds good - change pushed.

It looks backwards compatible since NotFound errors are also SlackError's? Check?

Yeah - all the specific errors inherit from the base SlackError. Aside from code which is disregarding inheritance (i.e. using error.class == SlackError instead of error.is_a? SlackError) this should be backwards compatible. Notably, rescue SlackError respects inheritance in this manner.

[dblock]

I don't see an UPGRADING change, but otherwise LGTM?

[eizengan]

I don't see an UPGRADING change, but otherwise LGTM?

Apologies! I misread that as just asking for a change to the version string. The new commit adds an entry to UPGRADING