Add a config to handle the display and the commands for the rovers#122
Open
r0n4n wants to merge 33 commits into
Open
Add a config to handle the display and the commands for the rovers#122r0n4n wants to merge 33 commits into
r0n4n wants to merge 33 commits into
Conversation
…arks-light-config Feat: color support for sparks light config
# Conflicts: # src/components/dialogs/app-settings/UAVsTab.jsx # src/components/uavs/UAVOperationsButtonGroup.jsx
`npx eslint --fix`
`npx prettier -w src`
Note, that this commit also includes fixes for some issues raised by `tseslint.configs.stylisticTypeChecked`, as it was enabled for a while instead of `tseslint.configs.stylistic` while going through the list.
Switch to the double underscore convention to avoid having a parent directory with no `index.d.ts`.
Author
|
I still need to fix the merge conflicts |
# Conflicts: # src/components/dialogs/app-settings/UAVsTab.jsx # src/components/uavs/UAVOperationsButtonGroup.jsx
…into rover_config # Conflicts: # src/components/dialogs/app-settings/UAVsTab.jsx
Author
|
@ntamas do you have any comment on my changes ? |
Member
|
Can you please change the target branch of the PR to I tried to change the target branch myself but apparently Github does not allow it if I am not the owner of the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config added to select the vehicle type:
Rover commands added for the rover configuration
Linked Skybrush server PR : skybrush-io/skybrush-server#13
Linked flockwave-spec : skybrush-io/flockwave-spec#4