[BUG]: Fixed the incorrect time propagation#2264
Open
Chetansahney wants to merge 4 commits intosktime:mainfrom
Open
[BUG]: Fixed the incorrect time propagation#2264Chetansahney wants to merge 4 commits intosktime:mainfrom
Chetansahney wants to merge 4 commits intosktime:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2264 +/- ##
=======================================
Coverage ? 86.93%
=======================================
Files ? 166
Lines ? 9783
Branches ? 0
=======================================
Hits ? 8505
Misses ? 1278
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #2263
What does this fix? Explain your changes.
This fixes an issue where history_time_idx and future_time_idx in pytorch_forecasting/data/_tslib_data_module.py could be generated from synthetic sequential indices (torch.arange(...)) instead of real timesteps.
The implementation now propagates true timesteps from processed_data["timestep"], preserving non-zero and irregular time indices.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Yes. Added:
pytorch_forecasting/data/tests/test_tslib_data_module.py::test_tslib_dataset_preserves_original_time_idx
Also validated with:
Any other comments?
There is a pre-existing unrelated baseline failure in full test_tslib_data_module.py (test_multivariate_target, list-vs-shape assertion), observed prior to this fix.
PR checklist