[BUG] Ensure CompositeMetric.__add__ and __mul__ operators are immutable#2254
Open
Muhammad-Rebaal wants to merge 5 commits intosktime:mainfrom
Open
[BUG] Ensure CompositeMetric.__add__ and __mul__ operators are immutable#2254Muhammad-Rebaal wants to merge 5 commits intosktime:mainfrom
CompositeMetric.__add__ and __mul__ operators are immutable#2254Muhammad-Rebaal wants to merge 5 commits intosktime:mainfrom
Conversation
Muhammad-Rebaal
requested review from
PranavBhatP,
benHeid,
fkiraly,
fnhirwa,
jdb78,
phoeenniixx and
yarnabrina
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2254 +/- ##
=======================================
Coverage ? 86.97%
=======================================
Files ? 166
Lines ? 9769
Branches ? 0
=======================================
Hits ? 8497
Misses ? 1272
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phoeenniixx
changed the title
CompositeMetric.__add__ and __mul__ operators are immutableCompositeMetric.__add__ and __mul__ operators are immutable
phoeenniixx
requested changes
Apr 11, 2026
Member
phoeenniixx
left a comment
phoeenniixx
left a comment
There was a problem hiding this comment.
Thanks!
Can you please add a minimal test to make sure it is working as expected?
Contributor
Author
|
Hi @phoeenniixx, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference : #2253
Description
The
__add__and__mul__operators forCompositeMetricwere previously modifyingselfin-place instead of returning newly instantiated objects. This violates typical python magic-method behavior and caused silent logical bugs where building multiple different composite sets out of a base metric modified the base itself permanently.Changes Made
__add__and__mul__in_base_metrics.pyto copy the internal arrays and construct a freshCompositeMetricinstance off the copied data.CC : @phoeenniixx , @PranavBhatP , @fkiraly