Skip to content

Refactored the model.py module#147

Open
kmadisa wants to merge 8 commits intomasterfrom
user/kmadisa/Code-refactoring
Open

Refactored the model.py module#147
kmadisa wants to merge 8 commits intomasterfrom
user/kmadisa/Code-refactoring

Conversation

@kmadisa
Copy link
Copy Markdown
Contributor

@kmadisa kmadisa commented Dec 8, 2021

Refactored the two huge methods setup_sim_quantities and add_actions, respectively. This is to make it easier to read, debug, and also maintain.

Signed-off-by: Katleho Madisa katleho.madisa47@gmail.com

Screenshots or code snippets (if appropriate):
N/A

Definition of Done Checklist

  • Code meets our python style guidelines?
  • Unit tested (coded, passed, included)?
  • Requested at least 2 reviewers?
  • Commented code, particularly in hard-to-understand areas?
  • Made corresponding changes to the documentation (e.g. Python documentation, System Engineering Documentation, version description updates, README file, etc)?

JIRA: N/A

Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Comment thread tango_simlib/model.py Outdated
@kmadisa kmadisa marked this pull request as ready for review June 10, 2022 13:04
@kmadisa kmadisa self-assigned this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant