Configure the device to manually push events#141
Draft
Conversation
> DevState can be used differently by developers. It is best that we don't force it on them on how to implement/handle their device state. This resulted in errornous behaviour for developers that expect the device to work fine when DevState is set to OFF.
Contributor
Author
|
…-manually-push-events
This adds the following two properties: - push_archive_events - push_change_events that will be used to indicate whether the server should push these events manually. The properties can be set globally to have the server push events for all attributes, but they can also be set on the attribute to override the global setting. Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
5c31439 to
ee33829
Compare
This config file defines a simple test device with 4 attributes. It has the global properties set to true: that is the push_archive_events, and the push_change_events properties.
The global values are overriden in the defined attributes:
- attribute1 uses the global values for both push archive and change events, respectively.
- attribute2 uses the global value for the push archive events but overrides the push change events value.
- attribute3 overrides the global push archive events value, but uses the global value for the push change events.
- attribute4 overrides the global values for both the push archive and change events, respectively.
I have also added a unit test to check that the SimDD.json files conforms to the SimDD.schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO...
Screenshots or code snippets (if appropriate):
Definition of Done Checklist
JIRA: JIRA_ISSUE_NUMBER