Skip to content

SPR1-660: Fix sources setting during delaycal observations #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spassmoor wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

SPR1-660: Fix sources setting during delaycal observations #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion observation/calibrate_delays.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class NoTargetsUpError(Exception):
if len(session.ants) < 4:
raise ValueError('Not enough receptors to do calibration - you '
'need 4 and you have %d' % (len(session.ants),))
sources_above_horizon = observation_sources.filter(el_limit_deg=opts.horizon)
sources_above_horizon = observation_sources.filter(el_limit_deg=opts.horizon+5)
Copy link
Copy Markdown
Contributor

@ludwigschwardt ludwigschwardt Feb 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add some documentation here, e.g.

Suggested change
sources_above_horizon = observation_sources.filter(el_limit_deg=opts.horizon+5)
# Lift horizon to avoid source setting while waiting for gains or during verification
sources_above_horizon = observation_sources.filter(el_limit_deg=opts.horizon+5)

That 5º buys you 20 minutes or so extra.

if not sources_above_horizon:
raise NoTargetsUpError("No targets are currently visible - "
"please re-run the script later")
Expand Down