G-API: oneVPL (simplification) oneVPL source finalization#5
Open
sivanov-work wants to merge 5 commits into
Open
G-API: oneVPL (simplification) oneVPL source finalization#5sivanov-work wants to merge 5 commits into
sivanov-work wants to merge 5 commits into
Conversation
sivanov-work
force-pushed
the
vpl_add_proc_engine
branch
from
54e58da to
1479770
Compare
sivanov-work
force-pushed
the
vpl_source_final
branch
from
96ebe68 to
b606a81
Compare
| ss << ex.what() << ". Unload VPL session: " << mfx_session; | ||
| const std::string str = ss.str(); | ||
| GAPI_LOG_WARNING(nullptr, str); | ||
| MFXClose(mfx_session); |
Collaborator
There was a problem hiding this comment.
It's the only MFXClose call. Are you sure there shouldn't been more of them?
Owner
Author
There was a problem hiding this comment.
yes, sure. It throws exception sequentially, that it reach dtor (because ctor delegation to OneVPLSource::Priv() was used before) where calls MFXUnload(mfx_handle);
As far I remember decoder deinit would be required - but it is impletented in DX11 PR.
| case MFX_ACCEL_MODE_VIA_VAAPI_GLX: return "MFX_ACCEL_MODE_VIA_VAAPI_GLX"; | ||
| case MFX_ACCEL_MODE_VIA_VAAPI_X11: return "MFX_ACCEL_MODE_VIA_VAAPI_X11"; | ||
| case MFX_ACCEL_MODE_VIA_VAAPI_WAYLAND: return "MFX_ACCEL_MODE_VIA_VAAPI_WAYLAND"; | ||
| case MFX_ACCEL_MODE_VIA_HDDLUNITE: return "MFX_ACCEL_MODE_VIA_HDDLUNITE"; |
Collaborator
There was a problem hiding this comment.
Please, align the returns here and below where applicable
Owner
Author
There was a problem hiding this comment.
would be fixed on master PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is the single one in series of opencv#20469
Aggregate all modules in oneVPLSource
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Build configuration